Beginnings of native Android build #110471
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Dec 6, 2024
steveisok
added
os-android
and removed
community-contribution
|
Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger |
grendello
force-pushed
the
dev/grendel/android-build-with-ndk
branch
from
c25fbd9 to
3d9da10
Compare
…ndk' into dev/grendel/android-build-with-ndk
3 tasks
…stem.Security.Cryptography.Native.Android. It will incorrectly try to install in the coreclr build
…em.native library for the singlefilehost
janvorli
reviewed
Dec 12, 2024
| @@ -80,7 +80,7 @@ build_native() | |||
|
|
|||
| if [[ "$targetOS" == android || "$targetOS" == linux-bionic ]]; then | |||
| # Keep in sync with $(AndroidApiLevelMin) in Directory.Build.props in the repository rooot | |||
| local ANDROID_API_LEVEL=28 | |||
| local ANDROID_API_LEVEL=29 | |||
There was a problem hiding this comment.
@grendello has mentioned in #110470 that even API level 28 is unfortunate and that we will want to support older API level, e.g. the originally used level 21.
So I wonder if moving to the level 29 is a good thing.
There was a problem hiding this comment.
It's not good in the long term and is something we should fix. Moving it to 29 for now allows us to not have to deal with emulated TLS usage.
There was a problem hiding this comment.
Unless we can fix it now, I don't think this should block progress. We can do it sometime down the road.
… R2R that acts like linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.